src: get and set all V8 flags from V8 (WIP)#47362
Closed
juanarbol wants to merge 2 commits intonodejs:mainfrom
Closed
src: get and set all V8 flags from V8 (WIP)#47362juanarbol wants to merge 2 commits intonodejs:mainfrom
juanarbol wants to merge 2 commits intonodejs:mainfrom
Conversation
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
Collaborator
|
Review requested:
|
Contributor
|
FWIW there was a PR for this sort of thing back in #40791. |
Member
Author
Nice! Thanks for the heads-up! |
Member
Author
|
I'll proceed to close this, I don't think this is going anywhere |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #46339
I will send the V8 changes to the V8 team, they will probably change some things :)
Anyway, this is just a PoC; please let me know if this is what we want in Node.js
V8 issue: https://bugs.chromium.org/p/v8/issues/detail?id=13900
V8 CL: https://chromium-review.googlesource.com/c/v8/v8/+/4393070
These are the printfs in the `node.cc` code
cc @joyeecheung @bnoordhuis